Skip to content

fix: package not installed tag set twice#66

Merged
joshsny merged 1 commit intoPostHog:mainfrom
leoffx:fix-tracking-package-not-installed-twice
Jun 23, 2025
Merged

fix: package not installed tag set twice#66
joshsny merged 1 commit intoPostHog:mainfrom
leoffx:fix-tracking-package-not-installed-twice

Conversation

@leoffx
Copy link
Copy Markdown
Contributor

@leoffx leoffx commented Jun 14, 2025

analytics.setTag(`${packageName.toLowerCase()}-installed`, installed); already tracks that the package was not installed, making it unnecessary for it to be called again in the !installed branch

@leoffx leoffx changed the title fix: package not installed tracked twice fix: package not installed tag set twice Jun 14, 2025
Copy link
Copy Markdown
Collaborator

@joshsny joshsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@joshsny joshsny merged commit 31fe452 into PostHog:main Jun 23, 2025
4 checks passed
daniloc pushed a commit that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants